lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Apr 2015 20:28:37 +0200 From: Paul Bolle <pebolle@...cali.nl> To: "pi-cheng.chen" <pi-cheng.chen@...aro.org> Cc: Viresh Kumar <viresh.kumar@...aro.org>, Mike Turquette <mturquette@...aro.org>, Matthias Brugger <matthias.bgg@...il.com>, "Joe.C" <yingjoe.chen@...iatek.com>, Eddie Huang <eddie.huang@...iatek.com>, Howard Chen <ibanezchen@...il.com>, fan.chen@...iatek.com, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, linaro-kernel@...ts.linaro.org, linux-mediatek@...ts.infradead.org Subject: Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver On Mon, 2015-04-20 at 17:27 +0800, pi-cheng.chen wrote: > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > +config ARM_MT8173_CPUFREQ > + bool "Mediatek MT8173 CPUFreq support" > + depends on ARCH_MEDIATEK && REGULATOR > + help > + This adds the CPUFreq driver support for Mediatek MT8173 SoC. > --- a/drivers/cpufreq/Makefile > +++ b/drivers/cpufreq/Makefile > +obj-$(CONFIG_ARM_MT8173_CPUFREQ) += mt8173-cpufreq.o ARM_MT8173_CPUFREQ is a bool symbol, so mt8173-cpufreq.o will never be part of a module. (If that's incorrect you can stop reading here.) > --- /dev/null > +++ b/drivers/cpufreq/mt8173-cpufreq.c > +#include <linux/module.h> I guess this include is not needed. And, for what it's worth, make ARCH=arm CROSS_COMPILE=arm-linux-gnu- drivers/cpufreq/mt8173-cpufreq.o compiles silently even if it's dropped. > +module_init(mt8173_cpufreq_driver_init); According to include/linux/init.h, for built-in only code, this is equivalent to device_initcall([...]). And two runs of make ARCH=arm CROSS_COMPILE=arm-linux-gnu- drivers/cpufreq/mt8173-cpufreq.i confirm that. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists