linux-kernel - Re: [PATCH 01/24] lustre: rip the private symlink nesting limit out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150420203544.GM889@ZenIV.linux.org.uk>
Date:	Mon, 20 Apr 2015 21:35:44 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Oleg Drokin <oleg.drokin@...el.com>,
	Neil Brown <neilb@...e.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux Filesystem Mailing List <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 01/24] lustre: rip the private symlink nesting limit out

On Mon, Apr 20, 2015 at 08:22:53PM +0100, Al Viro wrote:
> On Mon, Apr 20, 2015 at 01:08:16PM -0600, Andreas Dilger wrote:
> > On Apr 20, 2015, at 12:12 PM, Al Viro <viro@...IV.linux.org.uk> wrote:
> > > 
> > > From: Al Viro <viro@...iv.linux.org.uk>
> > > 
> > > Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> > 
> > Al, the patch itself looks good, thanks.
> > 
> > However, if this is applied at the start of the series it could
> > allow tests to easily cause a stack overflow during a bisection (I
> > don't think users would see a kernel in the middle of the series).
> > 
> > Could this be converted over to checking nd->link_count along with
> > the [02/24] patch until closer to the end of the series when the
> > recursion has been removed?
> 
> Er...  You do realize that struct nameidata is opaque for anything outside
> of fs/namei.c and has been that way for a while now?  Sure, we can export
> a helper that would return that and rip it out in the end of the series,
> but...

Actually, a cleaner solution would be to reorder that bunch (1--6) past
the link_path_walk() reorganization.  Done and force-pushed to the same
branch...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/