| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Apr 2015 21:37:03 +0100
From: Mark Brown <broonie@...nel.org>
To: Bert Vermeulen <bert@...t.com>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: rb4xx: Fix set_cs logic.
On Mon, Apr 20, 2015 at 03:53:25PM +0200, Bert Vermeulen wrote:
> As it turns out, the set_cs() enable parameter refers to the logic level
> on the CS pin, not the state of chip selection.
> This broke functionality of the LEDs behind the CPLD, or at least delayed
> the commands until another one came in to toggle CS.
No, the enable parameter *should* refer to chip select assertion (see
how we handle GPIO chip selects). However it's possible that this
device has an inverted chip select and should be registered with the
SPI_CS_HIGH flag?
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists