linux-kernel - Re: [PATCH 3/3] regulator: max8973: add DT parsing of platform specific parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150420211907.GP14892@sirena.org.uk>
Date:	Mon, 20 Apr 2015 22:19:07 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	robh+dt@...nel.org, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	lgirdwood@...il.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] regulator: max8973: add DT parsing of platform
 specific parameter

On Mon, Apr 20, 2015 at 06:24:17PM +0530, Laxman Dewangan wrote:

> +Optional properties:
> +
> +-maxim,externally-enable: boolean, externally control the regulator output
> +		enable/disable.

I'd have expected this to be enabled if a GPIO is provided to do the
control rather than having a specific property for it.

> +-maxim,enable-falling-slew-rate: boolean, enable falling slew rate.
> +-maxim,enable-active-discharge: boolean: enable active discharge.
> +-maxim,enable-frequency-shift: boolean, enable 9% frequency shift.
> +-maxim,enable-bias-control: boolean, enable bias control. By enabling this
> +		startup delay can be reduce to 20us from 220us.

It looks like we should be implementing the set_ramp_delay() operation
here?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)