linux-kernel - Re: [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANMBJr4Y2jVEZ7-fqN2upfBEMqjj9cx61uSLLN7gZvrK602NrQ@mail.gmail.com>
Date:	Mon, 20 Apr 2015 16:34:10 -0700
From:	Tyler Baker <tyler.baker@...aro.org>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	Shuah Khan <shuahkh@....samsung.com>,
	Kevin Hilman <khilman@...nel.org>,
	John Stultz <john.stultz@...aro.org>,
	Darren Hart <dvhart@...radead.org>,
	David Herrmann <dh.herrmann@...il.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building

On 20 April 2015 at 16:22, Andy Lutomirski <luto@...capital.net> wrote:
> On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@...aro.org> wrote:
>> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64.
>>
>> Cc: Andy Lutomirski <luto@...capital.net>
>> Signed-off-by: Tyler Baker <tyler.baker@...aro.org>
>> ---
>>  tools/testing/selftests/x86/Makefile | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
>> index be93945..a5ca38b 100644
>> --- a/tools/testing/selftests/x86/Makefile
>> +++ b/tools/testing/selftests/x86/Makefile
>> @@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
>>
>>  CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
>>
>> +all:
>> +
>
> This...
>
>>  UNAME_M := $(shell uname -m)
>>
>> +ifeq ($(CROSS_COMPILE),)
>>  # Always build 32-bit tests
>>  all: all_32
>> -
>>  # If we're on a 64-bit host, build 64-bit tests as well
>>  ifeq ($(UNAME_M),x86_64)
>>  all: all_64
>>  endif
>> +else
>> +# No dependency on all when cross building
>> +all:
>
> ...is redundant with this.  If you delete the "else" and "all:" here, then:

Ok, I will remove these bits from this patch. However, the else will
need to be added back in the next patch of the series to override the
default behavior of EMIT_TESTS and INSTALL_RULE if that you are ok
with that.

>
> Acked-by: Andy Lutomirski <luto@...nel.org>
>
>> +endif
>>
>>  all_32: check_build32 $(BINARIES_32)
>>
>> --
>> 2.1.4
>>
>
>
>
> --
> Andy Lutomirski
> AMA Capital Management, LLC

Tyler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/