linux-kernel - Re: [Y2038] [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <8072977.i0FsrGW3CD@wuerfel>
Date:	Tue, 21 Apr 2015 10:45:48 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	y2038@...ts.linaro.org
Cc:	Baolin Wang <baolin.wang@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Xunlei Pang <pang.xunlei@...aro.org>, peterz@...radead.org,
	benh@...nel.crashing.org, heiko.carstens@...ibm.com,
	paulus@...ba.org, cl@...ux.com,
	Heena Sirwani <heenasirwani@...il.com>,
	linux-arch@...r.kernel.org, linux-s390@...r.kernel.org,
	mpe@...erman.id.au, rafael.j.wysocki@...el.com,
	Andrew Hunter <ahh@...gle.com>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Paul Turner <pjt@...gle.com>, riel@...hat.com,
	Richard Cochran <richardcochran@...il.com>,
	schwidefsky@...ibm.com, John Stultz <john.stultz@...aro.org>,
	rth@...ddle.net, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	tj@...nel.org, linux390@...ibm.com, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [Y2038] [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k_clock callback functions

On Tuesday 21 April 2015 16:36:13 Baolin Wang wrote:
> On 21 April 2015 at 04:48, Thomas Gleixner <tglx@...utronix.de> wrote:
> 
> > On Mon, 20 Apr 2015, Baolin Wang wrote:
> > >  /* Set clock_realtime */
> > >  static int posix_clock_realtime_set(const clockid_t which_clock,
> > > -                                 const struct timespec *tp)
> > > +                                 const struct timespec64 *tp)
> > >  {
> > > -     return do_sys_settimeofday(tp, NULL);
> > > +     struct timespec ts = timespec64_to_timespec(*tp);
> > > +
> > > +     return do_sys_settimeofday(&ts, NULL);
> >
> > Sigh. No. We first provide a proper function for this, which takes a
> > timespec64, i.e. do_sys_settimeofday64() instead of having this
> > wrapper mess all over the place.
> >
> 
> Thanks for your comments,but if use do_sys_settimeofday64() here that
> will  introduce
> a security bug: do_sys_settimeofday contains a capability
> check that normally prevents non-root users from setting the time.
> 
> With your change, any user can set the system time.

He was asking for a new do_sys_settimeofday64 function to be added,
not using the low-level do_settimeofday64.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/