linux-kernel - Re: [PATCH 12/49] writeback: move backing_dev_info->bdi_stat[] into bdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Apr 2015 10:51:19 +0200
From:	Jan Kara <jack@...e.cz>
To:	Tejun Heo <tj@...nel.org>
Cc:	Jan Kara <jack@...e.cz>, axboe@...nel.dk,
	linux-kernel@...r.kernel.org, hch@...radead.org,
	hannes@...xchg.org, linux-fsdevel@...r.kernel.org,
	vgoyal@...hat.com, lizefan@...wei.com, cgroups@...r.kernel.org,
	linux-mm@...ck.org, mhocko@...e.cz, clm@...com,
	fengguang.wu@...el.com, david@...morbit.com, gthelen@...gle.com,
	Miklos Szeredi <miklos@...redi.hu>,
	Trond Myklebust <trond.myklebust@...marydata.com>
Subject: Re: [PATCH 12/49] writeback: move backing_dev_info->bdi_stat[] into
 bdi_writeback

On Mon 20-04-15 13:56:26, Tejun Heo wrote:
> On Mon, Apr 20, 2015 at 05:02:31PM +0200, Jan Kara wrote:
> >   Maybe bdi_wb_destroy() would be somewhat more descriptive than
> > bdi_wb_exit()? Otherwise the patch looks good to me. You can add:
> > Reviewed-by: Jan Kara <jack@...e.cz>
> 
> Hmmm... maybe, I don't know.  I feel weird matching up destroy with
> init instead of create.  Why is exit weird?
  I can easily understand what "initializing writeback structure" means but
"exiting writeback structure" doesn't really make sense to me. OTOH
"destroying writeback structure" does make sense to me. That's the only
reason.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/