linux-kernel - Re: [PATCH v3 3/8] selftests/breakpoints: emit skip and omit installation when tests are not compiled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55361B3B.3060505@arm.com>
Date:	Tue, 21 Apr 2015 10:41:15 +0100
From:	"Suzuki K. Poulose" <Suzuki.Poulose@....com>
To:	Tyler Baker <tyler.baker@...aro.org>,
	Shuah Khan <shuahkh@....samsung.com>
CC:	Kevin Hilman <khilman@...nel.org>,
	John Stultz <john.stultz@...aro.org>,
	Darren Hart <dvhart@...radead.org>,
	David Herrmann <dh.herrmann@...il.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 3/8] selftests/breakpoints: emit skip and omit installation
 when tests are not compiled

On 21/04/15 00:14, Tyler Baker wrote:
> The breakpoints test should only should be executed on x86 targets, so lets
> emit a skip and omit the installation when ARCH != x86.
>
> Acked-by: Michael Ellerman <mpe@...erman.id.au>
> Signed-off-by: Tyler Baker <tyler.baker@...aro.org>
> ---
>   tools/testing/selftests/breakpoints/Makefile | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 1822356..430b76d 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -8,7 +8,6 @@ ifeq ($(ARCH),x86_64)
>   	ARCH := x86
>   endif
>
> -
>   all:
>   ifeq ($(ARCH),x86)
>   	gcc breakpoint_test.c -o breakpoint_test
> @@ -20,5 +19,11 @@ TEST_PROGS := breakpoint_test
>
>   include ../lib.mk
>
> +install:
> +ifneq ($(ARCH),x86)
> +echo "Not an x86 target, can't install breakpoints selftests"
It would make more sense to send this to stderr than stdout, people may 
look for errors there.

Cheers
Suzuki

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/