linux-kernel - Re: [PATCH 12/49] writeback: move backing_dev_info->bdi_stat[] into bdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150421150559.GB32616@quack.suse.cz>
Date:	Tue, 21 Apr 2015 17:05:59 +0200
From:	Jan Kara <jack@...e.cz>
To:	Tejun Heo <tj@...nel.org>
Cc:	Jan Kara <jack@...e.cz>, axboe@...nel.dk,
	linux-kernel@...r.kernel.org, hch@...radead.org,
	hannes@...xchg.org, linux-fsdevel@...r.kernel.org,
	vgoyal@...hat.com, lizefan@...wei.com, cgroups@...r.kernel.org,
	linux-mm@...ck.org, mhocko@...e.cz, clm@...com,
	fengguang.wu@...el.com, david@...morbit.com, gthelen@...gle.com,
	Miklos Szeredi <miklos@...redi.hu>,
	Trond Myklebust <trond.myklebust@...marydata.com>
Subject: Re: [PATCH 12/49] writeback: move backing_dev_info->bdi_stat[] into
 bdi_writeback

On Tue 21-04-15 11:02:29, Tejun Heo wrote:
> On Tue, Apr 21, 2015 at 10:51:19AM +0200, Jan Kara wrote:
> >   I can easily understand what "initializing writeback structure" means but
> > "exiting writeback structure" doesn't really make sense to me. OTOH
> > "destroying writeback structure" does make sense to me. That's the only
> > reason.
> 
> We have enough cases where "exit" is used that way starting with
> module_exit() and all the accompanying __exit annotations and there
> are quite a few others.  I think it's enough to establish "exit" as
> the counterpart of "init" but I do agree that it felt a bit alien to
> me at the beginning too.
> 
> In general, I've been sticking with create/destroy if the object
> itself is being created or destroyed and init/exit if the object
> itself stays put across init/exit which is the case here.  This isn't
> quite universal but I think there exists enough of a pattern to make
> it worthwhile to stick to it.  As such, I'd like to stick to the
> current names if it isn't a big deal.
  It's not a big deal, so feel free to keep your naming. It's not a
function I'd stare at every day ;)

								Honza

-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/