linux-kernel - Re: [PATCH] perf/x86/intel: Add cpu_(prepare|starting|dying) for core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150421151216.GD3182@worktop.meeting.verilan.com>
Date:	Tue, 21 Apr 2015 17:12:16 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Jiri Olsa <jolsa@...nel.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf/x86/intel: Add cpu_(prepare|starting|dying) for
 core_pmu

On Tue, Apr 21, 2015 at 10:54:25AM +0200, Jiri Olsa wrote:
> @@ -2559,6 +2563,9 @@ static __initconst const struct x86_pmu core_pmu = {
>  	.guest_get_msrs		= core_guest_get_msrs,
>  	.format_attrs		= intel_arch_formats_attr,
>  	.events_sysfs_show	= intel_event_sysfs_show,

Could you also insert a little comment here how these methods are for
'funny' 'hardware' ?

> +	.cpu_prepare		= intel_pmu_cpu_prepare,
> +	.cpu_starting		= intel_pmu_cpu_starting,
> +	.cpu_dying		= intel_pmu_cpu_dying,
>  };
>  
>  struct intel_shared_regs *allocate_shared_regs(int cpu)
> -- 
> 1.9.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/