linux-kernel - Re: [PATCH] genirq: check irq_ack callback in handle_edge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJOTznWiLnXa8gcyKu-u77iu14RVpt6zNVQ1kHsUVRZU57PzOQ@mail.gmail.com>
Date:	Tue, 21 Apr 2015 18:28:30 +0300
From:	Sam Protsenko <semen.protsenko@...ballogic.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org,
	Grygorii Strashko <grygorii.strashko@...ballogic.com>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] genirq: check irq_ack callback in handle_edge_irq()
 before calling

On Tue, Apr 21, 2015 at 5:40 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
> No, it's not missing by chance. It's missing on purpose. The edge
> handler is designed to deal with edge type interrupt chips and those
> have an ACK by definition.
>
> You are fixing the wrong place. That GPIO expander is using the wrong
> flow handler. It should not use the edge handler at all.

Just missed comments for handle_edge_irq() function, explaining why
irq_ack is mandatory. So I just need to use handle_level_irq() in expander
driver (instead of handle_edge_irq()).

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/