linux-kernel - [PATCH 3.16.y-ckt 139/144] hpsa: fix memory leak in kdump hard reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1429630329-21748-140-git-send-email-luis.henriques@canonical.com>
Date:	Tue, 21 Apr 2015 16:32:04 +0100
From:	Luis Henriques <luis.henriques@...onical.com>
To:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	kernel-team@...ts.ubuntu.com
Cc:	Tomas Henzl <thenzl@...hat.com>, Don Brace <don.brace@...s.com>,
	Christoph Hellwig <hch@....de>,
	Masoud Sharbiani <msharbiani@...pensource.com>,
	Vinson Lee <vlee@...pensource.com>,
	Luis Henriques <luis.henriques@...onical.com>
Subject: [PATCH 3.16.y-ckt 139/144] hpsa: fix memory leak in kdump hard reset

3.16.7-ckt10 -stable review patch.  If anyone has any objections, please let me know.

------------------

From: Tomas Henzl <thenzl@...hat.com>

commit 03741d956eaac31264952e0afa181b62713892a5 upstream.

There is a potential memory leak in hpsa_kdump_hard_reset_controller.

Reviewed-by: Don Brace <don.brace@...s.com>
Reviewed-by: Scott Teel <scott.teel@...s.com>
Signed-off-by: Tomas Henzl <thenzl@...hat.com>
Signed-off-by: Don Brace <don.brace@...s.com>
Signed-off-by: Christoph Hellwig <hch@....de>
Cc: Masoud Sharbiani <msharbiani@...pensource.com>
Cc: Vinson Lee <vlee@...pensource.com>
Signed-off-by: Luis Henriques <luis.henriques@...onical.com>
---
 drivers/scsi/hpsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 28533dbd3407..35996a829046 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -5995,7 +5995,7 @@ static int hpsa_kdump_hard_reset_controller(struct pci_dev *pdev)
 	}
 	rc = write_driver_ver_to_cfgtable(cfgtable);
 	if (rc)
-		goto unmap_vaddr;
+		goto unmap_cfgtable;
 
 	/* If reset via doorbell register is supported, use that.
 	 * There are two such methods.  Favor the newest method.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/