linux-kernel - Re: [PATCH 5/5] Input: elan_i2c - Correct the x and y trace number.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D57B5549-A753-413D-BB03-47D553AFA41F@emc.com.tw>
Date:	Tue, 21 Apr 2015 08:47:20 +0800
From:	duson <dusonlin@....com.tw>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	黃世鵬 <phoenix@....com.tw>
Subject: Re: [PATCH 5/5] Input: elan_i2c - Correct the x and y trace number.

Hi Dmitry,

How about the description? Is it looks good for you?
Please let me know if you have any concern.

----------------------------------------------
Thank you,
ELAN Duson
✉ Email: dusonlin@....com.tw
----------------------------------------------





> duson <dusonlin@....com.tw> 於 2015年4月16日 上午9:37 寫道：
> 
> Hi Dmitry,
> 
> I double check with our firmware team and the SPEC, it looks like the subtract 1 just a misunderstanding.
> So, the correct should not subtract 1. For example, if the touchpad x resolution is 2800 and x trace number is 20,
> the pitch size of x should be 2800/20 = 140, not 2800/19 = 147.36. 
> 
> ----------------------------------------------
> Thanks,
> ELAN Duson
> ✉ Email: dusonlin@....com.tw
> ----------------------------------------------
> 
> 
> 
> 
> 
>> Dmitry Torokhov <dmitry.torokhov@...il.com> 於 2015年4月16日 上午1:47 寫道：
>> 
>> On Wed, Apr 15, 2015 at 09:55:43AM +0800, DusonLin wrote:
>>> The trace number does not need to subtract 1 now.
>> 
>> Could you provide a bit more of background for this change? Why don't we
>> need to decrement the number returned by the firmware anymore? We have
>> been running with the old numbers for many years...
>> 
>> Thanks!
>> 
>>> 
>>> Signed-off-by: Duson Lin <dusonlin@....com.tw>
>>> ---
>>> drivers/input/mouse/elan_i2c_i2c.c   |    4 ++--
>>> drivers/input/mouse/elan_i2c_smbus.c |    4 ++--
>>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>> 
>>> diff --git a/drivers/input/mouse/elan_i2c_i2c.c
>>> b/drivers/input/mouse/elan_i2c_i2c.c
>>> index 029941f..550f905 100644
>>> --- a/drivers/input/mouse/elan_i2c_i2c.c
>>> +++ b/drivers/input/mouse/elan_i2c_i2c.c
>>> @@ -356,8 +356,8 @@ static int elan_i2c_get_num_traces(struct i2c_client
>>> *client,
>>> 		return error;
>>> 	}
>>> 
>>> -	*x_traces = val[0] - 1;
>>> -	*y_traces = val[1] - 1;
>>> +	*x_traces = val[0];
>>> +	*y_traces = val[1];
>>> 
>>> 	return 0;
>>> }
>>> diff --git a/drivers/input/mouse/elan_i2c_smbus.c
>>> b/drivers/input/mouse/elan_i2c_smbus.c
>>> index 06a2bcd..0b04151 100644
>>> --- a/drivers/input/mouse/elan_i2c_smbus.c
>>> +++ b/drivers/input/mouse/elan_i2c_smbus.c
>>> @@ -268,8 +268,8 @@ static int elan_smbus_get_num_traces(struct i2c_client
>>> *client,
>>> 		return error;
>>> 	}
>>> 
>>> -	*x_traces = val[1] - 1;
>>> -	*y_traces = val[2] - 1;
>>> +	*x_traces = val[1];
>>> +	*y_traces = val[2];
>>> 
>>> 	return 0;
>>> }
>>> 
>> 
>> -- 
>> Dmitry
>> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/