linux-kernel - Re: [PATCH v2 1/5] media/v4l2-ctrls: volatiles should not generate CH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPybu_3WsYyRxcn0mxG=h3tOVXmxOT8Hm5Md07jE3mbF88HsWg@mail.gmail.com>
Date:	Tue, 21 Apr 2015 23:32:18 +0200
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:	Hans Verkuil <hans.verkuil@...co.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Arun Kumar K <arun.kk@...sung.com>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Antti Palosaari <crope@....fi>,
	linux-media <linux-media@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>
Subject: Re: [PATCH v2 1/5] media/v4l2-ctrls: volatiles should not generate CH_VALUE

Hello Laurent

On Tue, Apr 21, 2015 at 7:44 PM, Laurent Pinchart
<laurent.pinchart@...asonboard.com> wrote:
> Hi Ricardo,
>
> Thank you for the patch, and sorry for the late review (so late that the patch
> has already been merged).

No worries.

>
> On Friday 20 March 2015 14:30:46 Ricardo Ribalda Delgado wrote:
>> Volatile controls should not generate CH_VALUE events.
>
> What's the rationale for that ? I would actually expect the value change
> events to be more useful for volatile controls than non-volatile controls.
> Volatile controls can have their value changed by the hardware without
> software intervention, and it makes sense to me to report that to userspace.

Imagine a temperature register on the sensor. It is changing
constantly, resolution 10 milidegrees:

Do you want to get an event for every change? Who will poll the
temperature? The driver? The hardware will irq the driver....?

So I guess the less wrong solution is not throwing the ch_value event.

This is just my two cents, probably Hans has a much better global view :)

Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/