linux-kernel - Re: [PATCH v2] tpm: enable PPI for TPM 2.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Apr 2015 08:39:55 +0300
From:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	peterhuewe@....de, tpmdd-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, Marcel Selhorst <tpmdd@...horst.net>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	Tejun Heo <tj@...nel.org>, Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jianyu Zhan <nasa4836@...il.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Andrzej Hajda <a.hajda@...sung.com>, NeilBrown <neilb@...e.de>,
	Guenter Roeck <linux@...ck-us.net>,
	Simon Wunderlich <sw@...onwunderlich.de>
Subject: Re: [PATCH v2] tpm: enable PPI for TPM 2.0

On Tue, Apr 21, 2015 at 09:52:14PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 21, 2015 at 09:30:55PM +0300, Jarkko Sakkinen wrote:
> > -#define to_tpm_chip(n) container_of(n, struct tpm_chip, vendor)
> > +#define to_tpm_chip(n) container_of(dev, struct tpm_chip, dev)
> 
> That doesn't look correct to me...

Oops, no it doesn't (things worked though because the local variable
where this was used was named as dev). Thanks for pointing this out.

> thanks,
> 
> greg k-h

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/