linux-kernel - Re: [PATCH] zram: remove obsolete ZRAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Apr 2015 08:39:32 +0200
From:	Marcin Jabrzyk <m.jabrzyk@...sung.com>
To:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:	minchan@...nel.org, ngupta@...are.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	kyungmin.park@...sung.com
Subject: Re: [PATCH] zram: remove obsolete ZRAM_DEBUG option



On 22/04/15 01:55, Sergey Senozhatsky wrote:
> On (04/21/15 13:20), Marcin Jabrzyk wrote:
>> This config option doesn't provide any usage for zram.
>>
>
> agree, there is no pr_debug() in the current zram. so the change
> looks good to me.
>
>
> btw, same stands for zsmalloc (for the time being):
>
>   #ifdef CONFIG_ZSMALLOC_DEBUG
>   #define DEBUG
>   #endif
>
> seems to be useless. and there is even no ZSMALLOC_DEBUG config option
> in mm/Kconfig.
I've forgot to add this too in the patch, but I've saw it at some time 
earlier.
Anyway I'll prepare v2 with removal of both unused DEBUGs.
>
> so let's return back to it and clean up after the merge window.
I'll send v2 and eventually resend it after merge window closes.
>
> 	-ss
>
>> Signed-off-by: Marcin Jabrzyk <m.jabrzyk@...sung.com>
>> ---
>>   drivers/block/zram/Kconfig    | 10 +---------
>>   drivers/block/zram/zram_drv.c |  4 ----
>>   2 files changed, 1 insertion(+), 13 deletions(-)
>>
>> diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig
>> index 6489c0fd0ea6..386ba3d1a6ee 100644
>> --- a/drivers/block/zram/Kconfig
>> +++ b/drivers/block/zram/Kconfig
>> @@ -23,12 +23,4 @@ config ZRAM_LZ4_COMPRESS
>>   	default n
>>   	help
>>   	  This option enables LZ4 compression algorithm support. Compression
>> -	  algorithm can be changed using `comp_algorithm' device attribute.
>> -
>> -config ZRAM_DEBUG
>> -	bool "Compressed RAM block device debug support"
>> -	depends on ZRAM
>> -	default n
>> -	help
>> -	  This option adds additional debugging code to the compressed
>> -	  RAM block device driver.
>> +	  algorithm can be changed using `comp_algorithm' device attribute.
>> \ No newline at end of file
>> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
>> index fe67ebbe6c18..ea10f291d722 100644
>> --- a/drivers/block/zram/zram_drv.c
>> +++ b/drivers/block/zram/zram_drv.c
>> @@ -15,10 +15,6 @@
>>   #define KMSG_COMPONENT "zram"
>>   #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
>>
>> -#ifdef CONFIG_ZRAM_DEBUG
>> -#define DEBUG
>> -#endif
>> -
>>   #include <linux/module.h>
>>   #include <linux/kernel.h>
>>   #include <linux/bio.h>
>> --
>> 1.9.1
>>
>

Best regards,
-- 
Marcin Jabrzyk
Samsung R&D Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/