linux-kernel - Re: [PATCH perf/core 2/8] [BUGFIX] perf probe: Remove all probes matches given pattern at once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150422073343.GB21451@danjae.kornet>
Date:	Wed, 22 Apr 2015 16:33:43 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>, Jiri Olsa <jolsa@...hat.com>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH perf/core 2/8] [BUGFIX] perf probe: Remove all probes
 matches given pattern at once

Hi Masami,

On Tue, Apr 21, 2015 at 08:42:00PM +0900, Masami Hiramatsu wrote:
> @@ -2760,14 +2762,17 @@ int del_perf_probe_events(struct strlist *dellist)
>  
>  		pr_debug("Group: %s, Event: %s\n", group, event);
>  
> +		ret = ret2 = -ENOENT;
>  		if (namelist)
>  			ret = del_trace_probe_event(kfd, buf, namelist);
>  
> -		if (unamelist && ret != 0)
> -			ret = del_trace_probe_event(ufd, buf, unamelist);
> +		if (unamelist)
> +			ret2 = del_trace_probe_event(ufd, buf, unamelist);
>  
> -		if (ret != 0)
> -			pr_info("Info: Event \"%s\" does not exist.\n", buf);
> +		/* Since we can remove probes which already removed, no error  */
> +		if (ret != 0 && ret2 != 0)
> +			pr_debug("Event \"%s\" does not exist.\n", buf);

I think it'd be better checking 'ret == -ENOENT && ret2 == -ENOENT'
here since del_trace_probe_event() can return other error codes.

Thanks,
Namhyung


> +		ret = 0;
>  
>  		free(str);
>  	}
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/