linux-kernel - Re: [PATCH v3] perf tools: Document --children option in more detail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150422114949.GA25482@kernel.org>
Date:	Wed, 22 Apr 2015 08:49:49 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Taeung Song <treeze.taeung@...il.com>
Subject: Re: [PATCH v3] perf tools: Document --children option in more detail

Em Wed, Apr 22, 2015 at 03:09:06PM +0900, Namhyung Kim escreveu:
> On Tue, Apr 21, 2015 at 01:46:40PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > > +--no-children option on the command line or by adding 'report.children
> > > > > += false' or 'top.children = false' in the perf config file.

> > > > One can as well use the OPTION_FOO shortening mechanism and instead use:

> > > >      perf report --no-ch

> > > > Which is enough to disambiguate it from "--no-column-widths" and "--no-cpu".

> > > Are you saying that you want to add the short form instead of the full
> > > --no-chlidren name?  I think we need to verbose in the manpage at
> > > least and it might not work in the future if some --chxxx option is
> > > added.

> > Perhaps:

> > "--no-children option on the command line or by adding 'report.children = false'
> > or 'top.children = false' in the perf config file.

> > A shorter form on the command line can be used, for instance '--no-ch'
> > is unambiguous at the time of this writing."

> I don't think it belongs here.  The shorter form is not only for the
> --children, so it should be described in different place.

Well, I continue thinking it would add value, as the possibility of
shortening overly long options, like '--no-children' to reduce typing,
is handy, mentioning this possibility here and there, when such long
option names appears, would be of help.

But I won't insist, thanks for addressing the other suggestions,
applying.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/