linux-kernel - Re: [PATCH] pl2303, visor: Match I330 phone more precisely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150422123800.GA27882@kroah.com>
Date:	Wed, 22 Apr 2015 14:38:00 +0200
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Johan Hovold <johan@...nel.org>, Petr Slansky <slansky@....net>,
	Adam C Powell IV <hazelsct@....edu>
Cc:	"Jason A. Donenfeld" <Jason@...c4.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pl2303, visor: Match I330 phone more precisely

On Wed, Apr 22, 2015 at 01:20:38PM +0200, Johan Hovold wrote:
> On Wed, Apr 22, 2015 at 12:14:05PM +0200, Jason A. Donenfeld wrote:
> > Samsung has just released a portable USB3 SSD, coming in a very small
> > and nice form factor. It's USB ID is 04e8:8001, which unfortunately is
> > already used by the pl2303 USB serial driver and the Palm Visor driver
> > for the Samsung I330 phone cradle. Having pl2303 or visor pick up this
> > device ID results in conflicts with the usb-storage driver, which
> > handles the newly released portable USB3 SSD.
> 
> First of all, the device should not be claimed by both pl2303 and visor.
> This predates the git, but it looks like the device id should simply be
> removed from pl2303. Care to do that as a preparatory patch?

It was added back in 2004 in the 2.4.26 kernel release.  Petr Slansky
asked me to add it, and sent a patch as he had the device.

But before that, back in 2003 Adam emailed saying that the visor driver
worked with the device, and sent me a patch for it.  I didn't notice the
duplicate ids for well over a decade now :(

I'd bet this is really a pl2303 device, given that the visor driver was
just a "dumb" pipe to the device and the pilot sync tools never cared
about baud rates and the like, so odds are the visor entry should be
removed.

Petr, do you still have this device?  Is it still really a pl2303
device?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/