linux-kernel - Re: [PATCH RFC] x86: enforce inlining for atomics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwfQ-PSB3xt3x=Hab=LmgA8Dpoc=BVY5=fTQjcM=DCvRw@mail.gmail.com>
Date:	Tue, 21 Apr 2015 17:57:03 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Hagen Paul Pfeifer <hagen@...u.net>
Cc:	Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH RFC] x86: enforce inlining for atomics

On Tue, Apr 21, 2015 at 3:57 PM, Hagen Paul Pfeifer <hagen@...u.net> wrote:
>
> Is it possible that gcc is bedeviled because of inline assembler
> parts which brings confuse the internal scoring system?

yes, I have this memory of having seen that before - the size
heuristics for gcc getting confused by inlining. I'm wondering if
maybe it uses the size of the string to approximate the size, or just
uses some random variable.

It might be a good idea to mark things that are basically just
wrappers around a single (or a couple of) asm instruction to be
always_inline.

          Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/