linux-kernel - Re: [PATCH 01/16] x86, fpu: wrap get_xsave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1504221715410.13914@nanos>
Date:	Wed, 22 Apr 2015 17:17:08 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Dave Hansen <dave@...1.net>
cc:	Borislav Petkov <bp@...en8.de>, Oleg Nesterov <oleg@...hat.com>,
	linux-kernel@...r.kernel.org, x86@...nel.org,
	dave.hansen@...ux.intel.com, riel@...hat.com, sbsiddha@...il.com,
	luto@...capital.net, mingo@...hat.com, hpa@...or.com,
	fenghua.yu@...el.com
Subject: Re: [PATCH 01/16] x86, fpu: wrap get_xsave_addr() to make it safer

On Wed, 22 Apr 2015, Dave Hansen wrote:
> On 04/22/2015 06:31 AM, Borislav Petkov wrote:
> > I read tsk_get_xsave_field(@tsk, ) as give me the xsave field of @tsk
> > but doing used_math() we're querying current and I'm not sure
> > 
> > 	tsk == current
> > 
> > in all the call sites of tsk_get_xsave_field().
> 
> There aren't that many call sites. :)
> 
> But, yeah, tsk==current for all of them at the moment.

Is there a reason to have the task argument at all if thats only
intended for current?

Thanks,

	tglx



 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/