linux-kernel - Re: [PATCH 01/16] x86, fpu: wrap get_xsave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5537C609.7080608@sr71.net>
Date:	Wed, 22 Apr 2015 09:02:17 -0700
From:	Dave Hansen <dave@...1.net>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	Borislav Petkov <bp@...en8.de>, Oleg Nesterov <oleg@...hat.com>,
	linux-kernel@...r.kernel.org, x86@...nel.org,
	dave.hansen@...ux.intel.com, riel@...hat.com, sbsiddha@...il.com,
	luto@...capital.net, mingo@...hat.com, hpa@...or.com,
	fenghua.yu@...el.com
Subject: Re: [PATCH 01/16] x86, fpu: wrap get_xsave_addr() to make it safer

On 04/22/2015 08:17 AM, Thomas Gleixner wrote:
> On Wed, 22 Apr 2015, Dave Hansen wrote:
>> On 04/22/2015 06:31 AM, Borislav Petkov wrote:
>>> I read tsk_get_xsave_field(@tsk, ) as give me the xsave field of @tsk
>>> but doing used_math() we're querying current and I'm not sure
>>>
>>> 	tsk == current
>>>
>>> in all the call sites of tsk_get_xsave_field().
>>
>> There aren't that many call sites. :)
>>
>> But, yeah, tsk==current for all of them at the moment.
> 
> Is there a reason to have the task argument at all if thats only
> intended for current?

No, there is no good reason.  I'll rework it and resend the set.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/