lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Apr 2015 11:22:02 -0700 From: Linus Torvalds <torvalds@...ux-foundation.org> To: Josh Triplett <josh@...htriplett.org> Cc: Andy Lutomirski <luto@...capital.net>, Denys Vlasenko <dvlasenk@...hat.com>, Ingo Molnar <mingo@...nel.org>, Steven Rostedt <rostedt@...dmis.org>, Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>, Oleg Nesterov <oleg@...hat.com>, Frederic Weisbecker <fweisbec@...il.com>, Alexei Starovoitov <ast@...mgrid.com>, Will Drewry <wad@...omium.org>, Kees Cook <keescook@...omium.org>, X86 ML <x86@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett <josh@...htriplett.org> wrote: > > I do think my two-patch HAVE_COPY_THREAD_TLS series should go in fixing > this Ugh, I absolutely detesrt that patch. Don't make random crazy function signatures that depend on some config option. That's just evil. The patch is a mess of #ifdef's and should be shot in the head and staked with a silver stake to make sure it never re-appears. Either: (a) make the change for every architecture (b) have side-by-side interfaces. With different names! but not that disgusting "the calling conventions of these random functions are different on different architectures and we use a config flag to distinguish the cases". Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists