[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAPybu_3Ej2ecFDTiJVL9TfE=ZLFN2wLKE_nFL2WjMQtk+4LO_A@mail.gmail.com>
Date: Thu, 23 Apr 2015 09:28:39 +0200
From: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To: Rob Herring <robherring2@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Grant Likely <grant.likely@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Jakub Sitnicki <jsitnicki@...il.com>,
Vivek Goyal <vgoyal@...hat.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Jiang Liu <jiang.liu@...ux.intel.com>,
Mike Travis <travis@....com>,
Thierry Reding <treding@...dia.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 4/4] of/platform: Use platform_device interface
Hello Rob
On Wed, Apr 22, 2015 at 6:25 PM, Rob Herring <robherring2@...il.com> wrote:
>> This patch, replaces of_device_add() with platform_device_data().
>
> This doesn't match the change.
Thanks for catching it up. Will fix it and resend
>> - if (of_device_add(dev) != 0) {
>> + if (platform_device_add(dev) != 0) {
>
> Can't we now remove of_device_add?
Now it is only used by ibmebus
ricardo@...pili:~/linux-upstream$ git grep of_device_add
arch/powerpc/kernel/ibmebus.c: ret = of_device_add(dev);
drivers/of/device.c:int of_device_add(struct platform_device *ofdev)
drivers/of/device.c: return of_device_add(pdev);
include/linux/of_device.h:extern int of_device_add(struct
platform_device *pdev);
I think it can also use platform_device_add. I will prepare a patch to
finally remove of_device_add()
Thanks!
--
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists