linux-kernel - Re: [PATCH v2] Staging: rtl8712: Removed unused return variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150423155713.GK14154@mwanda>
Date:	Thu, 23 Apr 2015 18:57:13 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	"DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@...teon.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"florian.c.schilhabel@...glemail.com" 
	<florian.c.schilhabel@...glemail.com>,
	"thomas@...uk.net" <thomas@...uk.net>,
	"Babu, Viswanathan (V.)" <vbabu3@...teon.com>,
	"vthakkar1994@...il.com" <vthakkar1994@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] Staging: rtl8712: Removed unused return variable

This patch is a coccinelle thing, the reasoning behind it is that
literals are more clear than variables.

	return status; <-- Ambiguous.  This could be returning anything,
			   you have to look at the context.

	return 0;  <-- Clear.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/