linux-kernel - Re: [PATCH 7/8] ASoC: wm8998: Initial WM8998 codec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150423175455.GY22845@sirena.org.uk>
Date:	Thu, 23 Apr 2015 18:54:55 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:	lee.jones@...aro.org, linus.walleij@...aro.org, gnurou@...il.com,
	myungjoo.ham@...sung.com, cw00.choi@...sung.com,
	ckeepax@...nsource.wolfsonmicro.com,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, alsa-devel@...a-project.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 7/8] ASoC: wm8998: Initial WM8998 codec driver

On Thu, Apr 23, 2015 at 03:28:23PM +0100, Richard Fitzgerald wrote:

> I'm not sure this is really a routing or widget problem. Problem is that
> if the muxed inputs are analogue we need to provide separate ALSA controls
> for the left and right mux because it is allowed to use them as two
> independant mono channels with separate muxing. But if they are
> configured as digital the mux controls are ganged so must be set the

I understand this, it's what prompted my comment.

> same. I don't feel good about registering a single mux control if its
> digital and two if its analogue because that means the codec's control
> list depends on a pdata option. I could implement the control pair

I don't see that as a problem, it's not like the disallowed options
would ever meaningfully exist for users on an affected system.  Why do
you see this as a problem?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)