linux-kernel - Re: [PATCH RT 3.18] irq_work: Provide a soft-irq based queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150423170026.0de65c90@gandalf.local.home>
Date:	Thu, 23 Apr 2015 17:00:26 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Mike Galbraith <umgwanakikbuti@...il.com>
Cc:	Jan Kiszka <jan.kiszka@...mens.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	RT <linux-rt-users@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RT 3.18] irq_work: Provide a soft-irq based queue

On Thu, 23 Apr 2015 09:19:26 +0200
Mike Galbraith <umgwanakikbuti@...il.com> wrote:

> >   CC      kernel/irq_work.o
> > In file included from ../include/asm-generic/percpu.h:6:0,
> >                  from ../arch/x86/include/asm/percpu.h:522,
> >                  from ../arch/x86/include/asm/current.h:5,
> >                  from ../arch/x86/include/asm/processor.h:15,
> >                  from ../arch/x86/include/asm/irq_work.h:4,
> >                  from ../include/linux/irq_work.h:47,
> >                  from ../kernel/irq_work.c:11:
> > ../kernel/irq_work.c: In function ‘irq_work_queue_on’:
> > ../kernel/irq_work.c:85:17: error: ‘hirq_work_list’ undeclared 
> > (first use in this function)
> >         &per_cpu(hirq_work_list, cpu));
> 
> Aw poo, so that's just what I _thought_ it was for.

It helps optimization but does nothing for undefined symbols.

That said, why don't we clean up that irq_work code and at least
declare both lists, and get rid of all the #ifdefs. I wonder if gcc is
smart enough to not allocate a static variable if it happens to be
optimized out?

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/