linux-kernel - Re: [PATCH v2 4/8] moduleparam.h: add module_param_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87618noaj6.fsf@rustcorp.com.au>
Date:	Thu, 23 Apr 2015 11:45:09 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
Cc:	akpm@...ux-foundation.org, mingo@...nel.org, tj@...nel.org,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	keescook@...omium.org, casey@...aufler-ca.com,
	cocci@...teme.lip6.fr, "Luis R. Rodriguez" <mcgrof@...e.com>,
	Jani Nikula <jani.nikula@...el.com>
Subject: Re: [PATCH v2 4/8] moduleparam.h: add module_param_config_*() helpers

"Luis R. Rodriguez" <mcgrof@...not-panic.com> writes:
> From: "Luis R. Rodriguez" <mcgrof@...e.com>
>
> This adds a couple of bool module_param_config_*() helpers
> which are designed to let us easily associate a boolean
> module parameter with an associated kernel configuration
> option.

OK.

> Folks can use this to avoid what typically would
> be #ifdef eyesores around module parameter declarations.

Really?  So you use this in two patches:

  /* see the comment above the definition of WQ_POWER_EFFICIENT */
 -static bool wq_power_efficient = IS_ENABLED(CONFIG_WQ_POWER_EFFICIENT_DEFAULT);
 -module_param_named(power_efficient, wq_power_efficient, bool, 0444);
 +module_param_config_on_off(power_efficient, wq_power_efficient, 0444, CONFIG_WQ_POWER_EFFICIENT_DEFAULT);

And:

  static bool sig_enforce = IS_ENABLED(CONFIG_MODULE_SIG_FORCE);
  #ifndef CONFIG_MODULE_SIG_FORCE
 -module_param(sig_enforce, bool_enable_only, 0644);
 +module_param_config_on(sig_enforce, sig_enforce, 0644, CONFIG_MODULE_SIG_FORCE);
  #endif /* !CONFIG_MODULE_SIG_FORCE */

But neither actually, y'know, cleans up any #ifdefs.

Simplicity is a major virtue.  Readability is a major virtue.  Brevity
is only a minor virtue.

So I have applied the following patches:

[PATCH v2 1/8] kernel/params: constify struct kernel_param_ops uses
[PATCH v2 2/8] kernel/module.c: use generic module param operaters for sig_enforce
[PATCH v2 3/8] kernel/params.c: generalize bool_enable_only
[PATCH v2 5/8] kernel/workqueue.c: remove ifdefs over wq_power_efficient
[PATCH v2 7/8] kernel/module.c: avoid ifdefs for sig_enforce declaration

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/