linux-kernel - Re: [PATCH] exit,stats: /* obey this comment */

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55398C82.5000103@redhat.com>
Date:	Thu, 23 Apr 2015 20:21:22 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, Oleg Nesterov <oleg@...hat.com>,
	Michal Hocko <mhocko@...e.cz>
Subject: Re: [PATCH] exit,stats: /* obey this comment */

On 04/23/2015 05:47 PM, Andrew Morton wrote:
> On Thu, 23 Apr 2015 17:17:59 -0400 Rik van Riel <riel@...hat.com> wrote:
> 
>> There is a helpful comment in do_exit() that states we sync the
>> mm's RSS info before statistics gathering.
>>
>> The function that does the statistics gathering is called right
>> above that comment.
>>
>> Change the code to obey the comment.
>>
>> ...
>>
>> --- a/kernel/exit.c
>> +++ b/kernel/exit.c
>> @@ -711,10 +711,10 @@ void do_exit(long code)
>>  			current->comm, task_pid_nr(current),
>>  			preempt_count());
>>  
>> -	acct_update_integrals(tsk);
>>  	/* sync mm's RSS info before statistics gathering */
>>  	if (tsk->mm)
>>  		sync_mm_rss(tsk->mm);
>> +	acct_update_integrals(tsk);
>>  	group_dead = atomic_dec_and_test(&tsk->signal->live);
>>  	if (group_dead) {
>>  		hrtimer_cancel(&tsk->signal->real_timer);
> 
> I can't actually find anywhere where these counters are used in the
> accounting code.

Don't the get reported to userspace in things like this?

$ /usr/bin/time ls /dev
...
0.00user 0.00system 0:00.00elapsed 33%CPU (0avgtext+0avgdata
2652maxresident)k
0inputs+0outputs (0major+135minor)pagefaults 0swaps

Though admittedly this thing only reports maxresident...

I think there is some tool that reports the avg resident rss,
but I cannot remember what it is.

-- 
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/