linux-kernel - Re: [PATCH] crypto: x86/sha512_ssse3 - fixup for asm function prototype change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150424122012.GA31439@gondor.apana.org.au>
Date:	Fri, 24 Apr 2015 20:20:13 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc:	linux-crypto@...r.kernel.org, torvalds@...ux-foundation.org,
	smueller@...onox.de, davem@...emloft.net,
	linux-kernel@...r.kernel.org, bobbypowers@...il.com
Subject: Re: [PATCH] crypto: x86/sha512_ssse3 - fixup for asm function
 prototype change

On Fri, Apr 24, 2015 at 08:37:09AM +0200, Ard Biesheuvel wrote:
> Patch e68410ebf626 ("crypto: x86/sha512_ssse3 - move SHA-384/512
> SSSE3 implementation to base layer") changed the prototypes of the
> core asm SHA-512 implementations so that they are compatible with
> the prototype used by the base layer.
> 
> However, in one instance, the register that was used for passing the
> input buffer was reused as a scratch register later on in the code,
> and since the input buffer param changed places with the digest param
> -which needs to be written back before the function returns- this
> resulted in the scratch register to be dereferenced in a memory write
> operation, causing a GPF.
> 
> Fix this by changing the scratch register to use the same register as
> the input buffer param again.
> 
> Fixes: e68410ebf626 ("crypto: x86/sha512_ssse3 - move SHA-384/512 SSSE3 implementation to base layer")
> Reported-By: Bobby Powers <bobbypowers@...il.com>
> Tested-By: Bobby Powers <bobbypowers@...il.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

Patch applied.  Thanks!
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/