linux-kernel - Re: [PATCH] ipmi: Fix a problem that messages are not issued in run_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <553A3E7D.6040207@acm.org>
Date:	Fri, 24 Apr 2015 08:00:45 -0500
From:	Corey Minyard <minyard@....org>
To:	Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
CC:	openipmi-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi: Fix a problem that messages are not issued in run_to_completion
 mode

Ah, yes, you are correct.  Queued for 4.1.  Thanks.

-corey

On 04/22/2015 09:16 PM, Hidehiro Kawai wrote:
> start_next_msg() issues a message placed in smi_info->waiting_msg
> if it is non-NULL.  However, sender() sets a message to
> smi_info->curr_msg and NULL to smi_info->waiting_msg in the context
> of run_to_completion mode.  As the result, it leads an infinite
> loop by waiting the completion of unissued message when leaving
> dying message after kernel panic.
>
> sender() should set the message to smi_info->waiting_msg not
> curr_msg.
>
> Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
> Cc: Corey Minyard <minyard@....org>
> Cc: openipmi-developer@...ts.sourceforge.net
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/char/ipmi/ipmi_si_intf.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 5e90a18..3d49c70 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -942,8 +942,7 @@ static void sender(void                *send_info,
>  		 * If we are running to completion, start it and run
>  		 * transactions until everything is clear.
>  		 */
> -		smi_info->curr_msg = msg;
> -		smi_info->waiting_msg = NULL;
> +		smi_info->waiting_msg = msg;
>  
>  		/*
>  		 * Run to completion means we are single-threaded, no

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/