linux-kernel - Re: [PATCH 01/11] coresight-etm4x: Adding CoreSight ETM4x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Apr 2015 18:05:23 +0300
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:	gregkh@...uxfoundation.org, linux-arm-kernel@...ts.infradead.org,
	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
	kaixu.xia@...aro.org, zhang.chunyan@...aro.org
Subject: Re: [PATCH 01/11] coresight-etm4x: Adding CoreSight ETM4x driver


On Wed, 2015-04-22 at 16:40 -0600, Mathieu Poirier wrote:
> From: Pratik Patel <pratikp@...eaurora.org>
> 
> This driver manages the CoreSight ETMv4 (Embedded Trace Macrocell) IP block
> to support HW assisted tracing on ARMv7 and ARMv8 architectures.
> 
> Signed-off-by: Pratik Patel <pratikp@...eaurora.org>
> Signed-off-by: Kaixu Xia <xiakaixu@...wei.com>
> Signed-off-by: Mathieu Poirier poirier@...aro.org>

<snip>

> 

> +       pm_runtime_put(&adev->dev);
> +
> +       desc->type = CORESIGHT_DEV_TYPE_SOURCE;
> +       desc->subtype.source_subtype = CORESIGHT_DEV_SUBTYPE_SOURCE_PROC;
> +       desc->ops = &etm4_cs_ops;
> +       desc->pdata = pdata;
> +       desc->dev = dev;
> +       desc->groups = coresight_etmv4_groups;
> +       drvdata->csdev = coresight_register(desc);
> +       if (IS_ERR(drvdata->csdev)) {
> +               ret = PTR_ERR(drvdata->csdev);
> +               goto err_arch_supported;

double runtime put.

> +       }
> +
> +       dev_info(dev, "%s initialized\n", (char *)id->data);
> +
> +       if (boot_enable) {
> +               coresight_enable(drvdata->csdev);
> +               drvdata->boot_enable = true;
> +       }
> +
> +       return 0;
> +
> +err_arch_supported:
> +       pm_runtime_put(&adev->dev);
> +       if (--etm4_count == 0)
> +               unregister_hotcpu_notifier(&etm4_cpu_notifier);
> +       return ret;
> +}

Regards,
Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/