linux-kernel - Re: arm/arm64 perf build issue with mainline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150424162238.GD7313@arm.com>
Date:	Fri, 24 Apr 2015 17:22:38 +0100
From:	Will Deacon <will.deacon@....com>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	David Ahern <david.ahern@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mark Rutland <Mark.Rutland@....com>,
	Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: arm/arm64 perf build issue with mainline

On Fri, Apr 24, 2015 at 05:10:58PM +0100, Arnaldo Carvalho de Melo wrote:
> Em Thu, Apr 23, 2015 at 08:16:15AM -0600, David Ahern escreveu:
> > On 4/23/15 8:04 AM, Will Deacon wrote:
> > >+++ b/tools/perf/Makefile
> > >@@ -24,7 +24,7 @@ unexport MAKEFLAGS
> > >  # (To override it, run 'make JOBS=1' and similar.)
> > >  #
> > >  ifeq ($(JOBS),)
> > >-  JOBS := $(shell egrep -c '^processor|^CPU' /proc/cpuinfo 2>/dev/null)
> > >+  JOBS := $(shell getconf _NPROCESSORS_ONLN 2>/dev/null)
> > >    ifeq ($(JOBS),0)
> > >      JOBS := 1
> > >    endif
>  
> > Certainly a more robust way of doing it but I am concerned this
> > might end up breaking others. For Fedora at least getconf is in the
> > glibc-common package and there are users that do not build with
> > glibc. It is not clear if the build system for those environments
> > will have getconf.
> 
> Hum, perhaps check if getconf is present, if not fallback to the egrep
> -c? I'll try.

I don't have a SPARC machine to hand, but we could check that the character
immediately following "CPU" is a number [0-9].

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/