linux-kernel - Re: [PATCH] staging: slicoss: Break string into two lines.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1429901968.23327.8.camel@perches.com>
Date:	Fri, 24 Apr 2015 11:59:28 -0700
From:	Joe Perches <joe@...ches.com>
To:	Navya Sri Nizamkari <navyasri.tech@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: slicoss: Break string into two lines.

On Sat, 2015-04-25 at 00:22 +0530, Navya Sri Nizamkari wrote:
> This patch fixes the checkpatch.pl warning
> about line over 80 characters.

Don't give checkpatch any respect when it's being stupid.

> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
[]
> @@ -98,7 +98,8 @@
>  #include "slic.h"
>  
>  static uint slic_first_init = 1;
> -static char *slic_banner = "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)";
> +static char *slic_banner = "Alacritech SLIC Technology(tm) Server
> +			    and Storage Accelerator (Non-Accelerated)";

You've added a defect here as the string now contains a
newline and new tabs and spaces between "Server" and "and"


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/