linux-kernel - Re: [PATCH 2/2] block: remove unused BIO_RW_BLOCK and BIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49vbglxq92.fsf@segfault.boston.devel.redhat.com>
Date:	Fri, 24 Apr 2015 15:47:37 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Christoph Hellwig <hch@....de>
Cc:	Jens Axboe <axboe@...nel.dk>, Tejun Heo <tj@...nel.org>,
	Ming Lin <mlin@...nel.org>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] block: remove unused BIO_RW_BLOCK and BIO_EOF flags

Christoph Hellwig <hch@....de> writes:

> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index c2ee937..b0a5bff 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -112,8 +112,6 @@ struct bio {
>   * bio flags
>   */
>  #define BIO_UPTODATE	0	/* ok after I/O completion */
> -#define BIO_RW_BLOCK	1	/* RW_AHEAD set, and read/write would block */
> -#define BIO_EOF		2	/* out-out-bounds error */
>  #define BIO_SEG_VALID	3	/* bi_phys_segments valid */
>  #define BIO_CLONED	4	/* doesn't own data */
>  #define BIO_BOUNCED	5	/* bio is a bounce bio */

Any particular reason you elected to leave a hole in the numbering?  I
don't have a preference either way, but I don't think there's any harm
in compressing it.

-Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/