linux-kernel - Re: [PATCH 2/2] mm/hwpoison-inject: check PageLRU of hpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5539916E.80809@redhat.com>
Date:	Thu, 23 Apr 2015 19:42:22 -0500
From:	Dean Nelson <dnelson@...hat.com>
To:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] mm/hwpoison-inject: check PageLRU of hpage

On 04/16/2015 09:08 PM, Naoya Horiguchi wrote:
> Hwpoison injector checks PageLRU of the raw target page to find out whether
> the page is an appropriate target, but current code now filters out thp tail
> pages, which prevents us from testing for such cases via this interface.
> So let's check hpage instead of p.
> 
> Signed-off-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>

Acked-by: Dean Nelson <dnelson@...hat.com>


> ---
>   mm/hwpoison-inject.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git v4.0.orig/mm/hwpoison-inject.c v4.0/mm/hwpoison-inject.c
> index 2b3f933e3282..4ca5fe0042e1 100644
> --- v4.0.orig/mm/hwpoison-inject.c
> +++ v4.0/mm/hwpoison-inject.c
> @@ -34,12 +34,12 @@ static int hwpoison_inject(void *data, u64 val)
>   	if (!hwpoison_filter_enable)
>   		goto inject;
>   
> -	if (!PageLRU(p) && !PageHuge(p))
> -		shake_page(p, 0);
> +	if (!PageLRU(hpage) && !PageHuge(p))
> +		shake_page(hpage, 0);
>   	/*
>   	 * This implies unable to support non-LRU pages.
>   	 */
> -	if (!PageLRU(p) && !PageHuge(p))
> +	if (!PageLRU(hpage) && !PageHuge(p))
>   		goto put_out;
>   
>   	/*
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/