linux-kernel - Re: [PATCH v3 0/2] clk: improve handling of orphan clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8220650.vMaWphVIuC@diego>
Date:	Sat, 25 Apr 2015 15:44:11 +0200
From:	Heiko Stübner <heiko@...ech.de>
To:	Stefan Wahren <stefan.wahren@...e.com>
Cc:	Andrew Bresticker <abrestic@...omium.org>,
	linux-clk@...r.kernel.org, Michal Simek <michal.simek@...inx.com>,
	kernel@...gutronix.de, Georgi Djakov <georgi.djakov@...aro.org>,
	Pawel Moll <pawel.moll@....com>,
	Max Filippov <jcmvbkbc@...il.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Santosh Shilimkar <ssantosh@...nel.org>,
	Viresh Kumar <viresh.linux@...il.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Barry Song <baohua@...nel.org>, Alex Elder <elder@...aro.org>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Peter De Schrijver <pdeschrijver@...dia.com>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	linux-arm-kernel@...ts.infradead.org,
	Dinh Nguyen <dinguyen@...nsource.altera.com>,
	linux-kernel@...r.kernel.org, emilio@...pez.com.ar,
	dianders@...omium.org, Jason Cooper <jason@...edaemon.net>,
	Chao Xie <chao.xie@...vell.com>, Tero Kristo <t-kristo@...com>,
	Gabriel FERNANDEZ <gabriel.fernandez@...com>,
	mturquette@...aro.org, sboyd@...eaurora.org
Subject: Re: [PATCH v3 0/2] clk: improve handling of orphan clocks

Hi Stefan,

Am Samstag, 25. April 2015, 14:23:39 schrieb Stefan Wahren:
> > Heiko Stuebner <heiko@...ech.de> hat am 22. April 2015 um 22:53
> > geschrieben:
> > 
> > 
> > Using orphan clocks can introduce strange behaviour as they don't have
> > rate information at all and also of course don't track
> > 
> > [...]
> > 
> > 
> > As this changes the behaviour for orphan clocks, it would of course
> > benefit from more testing than on my Rockchip boards. To keep the
> > recipent-list reasonable and not spam to much I selected one (the topmost)
> > from the get_maintainer output of each drivers/clk entry.
> > Hopefully some will provide Tested-by-tags :-)
> 
> excuse me for my naive question, but what kind of tests do you expect
> (beside applying the patches)?

just a "everything that worked before still works" :-)

Using orphaned clocks should already produce strange issues most of the time - 
for example I see clk_disable mismatches when suspending a rk3288 board, 
before this patchset.

But nevertheless we now disallow the usage of orphaned clocks completely while 
before it was possible to knowingly/unknowingly use them.

And while hopefully most drivers should handle an EPROBE_DEFER from clk_get 
just fine, there may still be one or two lurking around that would need fixing 
then ;-)


Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/