linux-kernel - Re: [PATCH v2 1/2] libata: Add helper to determine when PHY events should be ignored

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150425205334.GA1499@htj.duckdns.org>
Date:	Sat, 25 Apr 2015 16:53:34 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Gabriele Mazzotta <gabriele.mzt@...il.com>
Cc:	stripathi@....com, linux-kernel@...r.kernel.org,
	linux-ide@...r.kernel.org
Subject: Re: [PATCH v2 1/2] libata: Add helper to determine when PHY events
 should be ignored

On Sat, Apr 25, 2015 at 07:52:36PM +0200, Gabriele Mazzotta wrote:
> +bool sata_lpm_ignore_phy_events(struct ata_link *link)
> +{
> +	/* if LPM is enabled, PHYRDY doesn't mean anything */
> +	return !!(link->lpm_policy > ATA_LPM_MAX_POWER);

This gets removed by the next patch so it doesn't matter but there's
no need to do !! here.  The expression is already bool and even if not
casting to bool can't yield any other result.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/