[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150424.235936.1118209212526994419.davem@davemloft.net>
Date: Fri, 24 Apr 2015 23:59:36 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: joe@...ches.com
Cc: m.grzeschik@...gutronix.de, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH 06/21] ARCNET: com20020: remove unneeded macros
From: Joe Perches <joe@...ches.com>
Date: Fri, 24 Apr 2015 16:04:45 -0700
> On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote:
>> The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK
>> and ADIAGSTATUS are unnecessary indirections to the use of registers.
>> This patch removes them and improves the readability of the code.
>
> This breaks compilation.
>
> Please compile test your patches before sending them.
This makes this patch series even more unacceptable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists