lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1429937777.23327.60.camel@perches.com>
Date:	Fri, 24 Apr 2015 21:56:17 -0700
From:	Joe Perches <joe@...ches.com>
To:	Robert Callicotte <rcallicotte@...il.com>
Cc:	greg@...ah.com, lidza.louina@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dgnc: Cleanup of unnecessary braces

On Fri, 2015-04-24 at 23:48 -0500, Robert Callicotte wrote:
> Removed curly braces and trailing whitespace from else clause.

Do please compile the files modified by your patches
_before_ sending them.

> Signed-off-by: Robert Callicotte <rcallicotte@...il.com>
> ---
>  drivers/staging/dgnc/dgnc_tty.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index ce4187f..2418150 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -898,9 +898,8 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
>  			ch->ch_bd->bd_ops->send_start_character(ch);
>  		}
>  		/* No FLOW */
> -		else {
> +		else
>  			/* Nothing needed. */
> -		}
>  	}
>  }
>  



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ