linux-kernel - [PATCH -next] crypto: api: Do not access module name directly from module structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1429891083-525-1-git-send-email-linux@roeck-us.net>
Date:	Fri, 24 Apr 2015 08:58:03 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	Guenter Roeck <linux@...ck-us.net>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: [PATCH -next] crypto: api: Do not access module name directly from module structure

'struct module' is only fully declared if CONFIG_MODULES is configured.
If not, the build fails with

crypto/algapi.c: In function 'crypto_check_module_sig':
crypto/algapi.c:49:12: error: dereferencing pointer to incomplete type

Fixes: 59afdc7b3214 ("crypto: api - Move module sig ifdef into accessor
	function")
Cc: Herbert Xu <herbert@...dor.apana.org.au>
Cc: Rusty Russell <rusty@...tcorp.com.au>
Signed-off-by: Guenter Roeck <linux@...ck-us.net>
---
Seen in next-20150424.

 crypto/algapi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/algapi.c b/crypto/algapi.c
index c63836f4ff64..3103e6a1282e 100644
--- a/crypto/algapi.c
+++ b/crypto/algapi.c
@@ -46,7 +46,7 @@ static inline void crypto_check_module_sig(struct module *mod)
 {
 	if (fips_enabled && mod && !module_sig_ok(mod))
 		panic("Module %s signature verification failed in FIPS mode\n",
-		      mod->name);
+		      module_name(mod));
 }
 
 static int crypto_check_alg(struct crypto_alg *alg)
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/