linux-kernel - Re: [PATCH V2 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150425113509.GB31708@sirena.org.uk>
Date:	Sat, 25 Apr 2015 12:35:09 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Kevin Cernekee <cernekee@...omium.org>
Cc:	lgirdwood@...il.com, lars@...afoo.de, dgreid@...omium.org,
	abrestic@...omium.org, olofj@...omium.org,
	alsa-devel@...a-project.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 3/4] ASoC: tas571x: New driver for TI TAS571x power
 amplifiers

On Fri, Apr 24, 2015 at 03:36:47PM -0700, Kevin Cernekee wrote:

> +			gpiod_set_value(priv->pdn_gpio, 0);
> +			usleep_range(5000, 6000);
> +
> +			regcache_cache_only(priv->regmap, false);
> +			ret = regcache_sync_region(priv->regmap, 0,
> +				priv->chip->regmap_config->max_register, false);
> +			if (ret)
> +				return ret;

This is also a problem with your first patch BTW - even if we are going
to add an argument we shouldn't be having drivers do _sync_region() to
sync the entire register map, that's just ugly.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)