linux-kernel - Re: [RFC PATCH 1/6] sched/rt: Provide new check_preempt_equal_prio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150426143303.07b62235@gandalf.local.home>
Date:	Sun, 26 Apr 2015 14:33:03 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Xunlei Pang <xlpang@....com>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Juri Lelli <juri.lelli@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Xunlei Pang <pang.xunlei@...aro.org>
Subject: Re: [RFC PATCH 1/6] sched/rt: Provide new
 check_preempt_equal_prio_common()

On Mon, 27 Apr 2015 01:10:53 +0800
Xunlei Pang <xlpang@....com> wrote:

> From: Xunlei Pang <pang.xunlei@...aro.org>
> 
> When p is queued, there may be other tasks already queued at the
> same priority in the "run queue", so we should peek the most front
> one to do the equal priority preemption.
> 
> This patch modifies check_preempt_equal_prio() and provides new
> check_preempt_equal_prio_common() to do the common preemption.

This change log fails to explain why this is needed.

> 
> There are also other cases to be added calling the new interface
> in the following patches.

A change log should stand on its own, and not just say, other patches
will use it. It can say that, if it fully explains why the change is
needed.

Also note, you are missing a 0/6 email that explains the entire
rational of the patch set, such that people understand more what you
intend to accomplish. We have no idea what your overall goal is.

-- Steve

> 
> Signed-off-by: Xunlei Pang <pang.xunlei@...aro.org>
> ---
>  kernel/sched/rt.c | 70 ++++++++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 54 insertions(+), 16 deletions(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/