[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <553D3329.6080002@kernel.org>
Date: Sun, 26 Apr 2015 19:49:13 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Irina Tirdea <irina.tirdea@...el.com>, linux-iio@...r.kernel.org,
Hartmut Knaack <knaack.h@....de>
CC: linux-kernel@...r.kernel.org, Vlad Dogaru <vlad.dogaru@...el.com>
Subject: Re: [PATCH v2 10/17] iio: accel: mma9553: use GENMASK
On 13/04/15 16:40, Irina Tirdea wrote:
> Use GENMASK instead of BIT or direct value to
> define a mask.
>
> Signed-off-by: Irina Tirdea <irina.tirdea@...el.com>
> Suggested-by: Hartmut Knaack <knaack.h@....de>
Applied.
> ---
> drivers/iio/accel/mma9553.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c
> index a6b74de..47cb14b 100644
> --- a/drivers/iio/accel/mma9553.c
> +++ b/drivers/iio/accel/mma9553.c
> @@ -63,8 +63,8 @@
> #define MMA9553_MASK_STATUS_STEPCHG BIT(13)
> #define MMA9553_MASK_STATUS_ACTCHG BIT(12)
> #define MMA9553_MASK_STATUS_SUSP BIT(11)
> -#define MMA9553_MASK_STATUS_ACTIVITY (BIT(10) | BIT(9) | BIT(8))
> -#define MMA9553_MASK_STATUS_VERSION 0x00FF
> +#define MMA9553_MASK_STATUS_ACTIVITY GENMASK(10, 8)
> +#define MMA9553_MASK_STATUS_VERSION GENMASK(7, 0)
>
> #define MMA9553_REG_STEPCNT 0x02
> #define MMA9553_REG_DISTANCE 0x04
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists