linux-kernel - Re: [PATCH v5 1/3] ARM: pxa: pxa_cplds: add lubbock and mainstone IO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1430075422.2927.131.camel@x220>
Date:	Sun, 26 Apr 2015 21:10:22 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:	Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/3] ARM: pxa: pxa_cplds: add lubbock and mainstone IO

On Sat, 2015-04-25 at 23:13 +0200, Robert Jarzmik wrote:
> --- a/arch/arm/mach-pxa/Kconfig
> +++ b/arch/arm/mach-pxa/Kconfig
 
> +config PXA_SYSTEMS_CPLDS
> +	bool "Motherboard cplds"
> +	def_bool ARCH_LUBBOCK || MACH_MAINSTONE

Just
	default ARCH_LUBBOCK || MACH_MAINSTONE

should be enough.

> +	select MFD_CORE
> +	help
> +	  This driver supports the Lubbock and Mainstone multifunction chip
> +	  found on the pxa25x development platform system (Lubbock) and pxa27x
> +	  development platform system (Mainstone). This IO board supports the
> +	  interrupts handling, ethernet controller, flash chips, etc ...

> --- a/arch/arm/mach-pxa/Makefile
> +++ b/arch/arm/mach-pxa/Makefile
 
> +obj-$(CONFIG_PXA_SYSTEMS_CPLDS)	+= pxa_cplds_irqs.o

PXA_SYSTEMS_CPLDS is a bool symbol, so pxa_cplds_irqs.o will never be
part of a module, correct?

> --- /dev/null
> +++ b/arch/arm/mach-pxa/pxa_cplds_irqs.c

> +#include <linux/module.h>

Since this is built-in only code this include is probably unneeded.

> +MODULE_DEVICE_TABLE(of, cplds_id_table);

MODULE_DEVICE_TABLE() will be preprocessed away for built-in only code.

> +module_platform_driver(cplds_driver);

Speaking from memory: for built-in only code this is equivalent to
having a wrapper that only calls
	platform_driver_register(&cplds_driver);

and have that wrapper marked as
	device_initcall()

> +MODULE_DESCRIPTION("PXA Cplds interrupts driver");
> +MODULE_AUTHOR("Robert Jarzmik <robert.jarzmik@...e.fr>");
> +MODULE_LICENSE("GPL");

These three macros will effectively be preprocessed away for built-in
only code.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/