linux-kernel - Re: [PATCH v7 2/3] leds: ktd2692: add device tree bindings for ktd2692

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 27 Apr 2015 15:32:58 +0900
From:	Ingi Kim <ingi2.kim@...sung.com>
To:	Jacek Anaszewski <j.anaszewski81@...il.com>
Cc:	sakari.ailus@....fi, j.anaszewski@...sung.com,
	varkabhadram@...il.com, joe@...ches.com, sw0312.kim@...sung.com,
	cw00.choi@...sung.com, jh80.chung@...sung.com,
	ideal.song@...sung.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v7 2/3] leds: ktd2692: add device tree bindings for ktd2692

Hi Jacek,

Thanks for the review.


On 2015년 04월 24일 22:29, Jacek Anaszewski wrote:
> On Thu, 23 Apr 2015 22:18:04 +0900
> Hi Ingi,
> 
> Ingi Kim <ingi2.kim@...sung.com> wrote:
> 
>> This patch adds the device tree bindings for ktd2692 flash LEDs.
>> Add Optional properties of child node for Flash LED
>>
>> Signed-off-by: Ingi Kim <ingi2.kim@...sung.com>
>> Acked-by: Seung-Woo Kim <sw0312.kim@...sung.com>
>> ---
>>  .../devicetree/bindings/leds/leds-ktd2692.txt      | 47
>> ++++++++++++++++++++++ 1 file changed, 47 insertions(+)
>>  create mode 100644
>> Documentation/devicetree/bindings/leds/leds-ktd2692.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt
>> b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt new file
>> mode 100644 index 0000000..708f2d4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt
>> @@ -0,0 +1,47 @@
>> +* Kinetic Technologies - KTD2692 Flash LED Driver
>> +
>> +KTD2692 is the ideal power solution for high-power flash LEDs.
>> +It uses ExpressWire single-wire programming for maximum flexibility.
>> +
>> +The ExpressWire interface through CTRL pin can control LED on/off and
>> +enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode
>> current, +Flash timeout, LVP(low voltage protection).
>> +
>> +Also, When the AUX pin is pulled high while CTRL pin is high,
>> +LED current will be ramped up to the flash-mode current level.
>> +
>> +Required properties:
>> +- compatible: "kinetic,ktd2692"
>> +- ctrl-gpio : gpio pin in order control CTRL pin
>> +- aux-gpio : gpio pin in order control AUX pin
>> +
>> +Optional properties:
>> +- vin-supply : "vin" LED supply (2.7V to 5.5V)
>> +  See Documentation/devicetree/bindings/regulator/regulator.txt
>> +
>> +A discrete LED element connected to the device must be represented
>> by a child +node - see
>> Documentation/devicetree/bindings/leds/common.txt. +
>> +Required properties for flash LED child nodes:
>> +  See Documentation/devicetree/bindings/leds/common.txt
>> +- flash-max-microamp : Flash LED maximum current
>> +  Formula : I(mA) = 15000 / Rset
>> +- flash-max-timeout-us : Flash LED maximum timeout
> 
> Patch [1] makes the led-max-microamp property mandatory for
> the LEDs with configurable current for non-flash modes.
> 
> It hasn't been merged yet as we are waiting for ack from DT maintainer.
> 
> 

Ok, I'll add it.

I saw discussion about introduction of new properties for Flash LED,
I also hope that patch[1] would be merged as soon as possible :)

>> +
>> +Optional properties for flash LED child nodes:
>> +- label : see Documentation/devicetree/bindings/leds/common.txt
>> +
>> +Example:
>> +
>> +ktd2692 {
>> +	compatible = "kinetic,ktd2692";
>> +	ctrl-gpio = <&gpc0 1 0>;
>> +	aux-gpio = <&gpc0 2 0>;
>> +	vin-supply = <&vbat>;
>> +
>> +	flash-led {
>> +		label = "ktd2692-flash";
>> +		flash-max-microamp = <1500000>;
>> +		flash-max-timeout-us = <1835000>;
>> +	};
>> +};
> 
> [1] [PATCH v6] DT: leds: Improve description of flash LEDs related
> properties
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/