lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 27 Apr 2015 10:43:14 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Yoshinori Sato <ysato@...rs.sourceforge.jp>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH v9 02/17] h8300: UAPI headers

On Monday 27 April 2015 14:35:09 Yoshinori Sato wrote:
> diff --git a/arch/h8300/include/uapi/asm/auxvec.h b/arch/h8300/include/uapi/asm/auxvec.h
> new file mode 100644
> index 0000000..1d36fe38
> --- /dev/null
> +++ b/arch/h8300/include/uapi/asm/auxvec.h
> @@ -0,0 +1,4 @@
> +#ifndef __ASMH8300_AUXVEC_H
> +#define __ASMH8300_AUXVEC_H
> +
> +#endif

> diff --git a/arch/h8300/include/uapi/asm/swab.h b/arch/h8300/include/uapi/asm/swab.h
> new file mode 100644
> index 0000000..7847e56
> --- /dev/null
> +++ b/arch/h8300/include/uapi/asm/swab.h
> @@ -0,0 +1 @@
> +#include <asm-generic/swab.h>


Two more files that you can just use in the generic version here.

> diff --git a/arch/h8300/include/uapi/asm/signal.h b/arch/h8300/include/uapi/asm/signal.h
> new file mode 100644
> index 0000000..af3a6c3
> --- /dev/null
> +++ b/arch/h8300/include/uapi/asm/signal.h

I think you should use the asm-generic version here, not just to make your
code smaller, but also to ensure you have the gneeric ABI.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ