linux-kernel - Re: [PATCH 2/2] drm: fix a memleak on mutex failure path

Open Source and information security mailing list archives

Message-ID: <87d22qc5lr.fsf@intel.com>
Date:	Mon, 27 Apr 2015 11:56:00 +0300
From:	Jani Nikula <jani.nikula@...ux.intel.com>
To:	green@...uxhacker.ru, David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org
Cc:	Daniel Vetter <daniel.vetter@...ll.ch>,
	kernel-janitors@...r.kernel.org,
	open list <linux-kernel@...r.kernel.org>,
	Oleg Drokin <green@...uxhacker.ru>
Subject: Re: [PATCH 2/2] drm: fix a memleak on mutex failure path

On Sun, 26 Apr 2015, green@...uxhacker.ru wrote:
> From: Oleg Drokin <green@...uxhacker.ru>
>
> Need to free just allocated ctx allocation if we cannot
> get our config mutex.
>
> This one has been flagged by kbuild bot all the way back in August,
> but somehow nobody picked it up:
> https://lists.01.org/pipermail/kbuild/2014-August/001691.html
>
> Found with smatch.
>
> Signed-off-by: Oleg Drokin <green@...uxhacker.ru>
> CC: Daniel Vetter <daniel.vetter@...ll.ch>

The function has another leaking failure path, would be nice to have
that fixed too. Maybe with a common out label.

BR,
Jani.

> ---
>  drivers/gpu/drm/drm_modeset_lock.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_modeset_lock.c b/drivers/gpu/drm/drm_modeset_lock.c
> index 51cc47d..1e8c52f 100644
> --- a/drivers/gpu/drm/drm_modeset_lock.c
> +++ b/drivers/gpu/drm/drm_modeset_lock.c
> @@ -80,8 +80,10 @@ int __drm_modeset_lock_all(struct drm_device *dev,
>  		return -ENOMEM;
>  
>  	if (trylock) {
> -		if (!mutex_trylock(&config->mutex))
> +		if (!mutex_trylock(&config->mutex)) {
> +			kfree(ctx);
>  			return -EBUSY;
> +		}
>  	} else {
>  		mutex_lock(&config->mutex);
>  	}
> -- 
> 2.1.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives