linux-kernel - Re: [PATCH v9 07/17] h8300: miscellaneous functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2426012.sTXZYqKJ88@wuerfel>
Date:	Mon, 27 Apr 2015 10:57:10 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Yoshinori Sato <ysato@...rs.sourceforge.jp>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH v9 07/17] h8300: miscellaneous functions

On Monday 27 April 2015 14:35:14 Yoshinori Sato wrote:
> +void dma_sync_single_for_device(struct device *dev, dma_addr_t handle,
> +				size_t size, enum dma_data_direction dir)
> +{
> +}
> +EXPORT_SYMBOL(dma_sync_single_for_device);
> +
> +void dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg,
> +			    int nents, enum dma_data_direction dir)
> +{
> +	int i;
> +
> +	for (i = 0; i < nents; sg++, i++)
> +		dma_sync_single_for_device(dev, sg->dma_address,
> +					   sg->length, dir);
> +}
> +EXPORT_SYMBOL(dma_sync_sg_for_device);
> +
> +dma_addr_t dma_map_single(struct device *dev, void *addr, size_t size,
> +			  enum dma_data_direction dir)
> +{
> +	dma_addr_t handle = virt_to_bus(addr);
> +
> +	dma_sync_single_for_device(dev, handle, size, dir);
> +	return handle;
> +}
> +EXPORT_SYMBOL(dma_map_single);


As this all doesn't do anything, and your dma-mapping.h header explains
that the architecture is cache-coherent, just remove these functions,
and replace them with empty 'static inline' helpers in that header.

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/