linux-kernel - Re: [PATCH v6 6/8] virtio: add explicit big-endian support to memory accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150427111422.10564c9e.cornelia.huck@de.ibm.com>
Date:	Mon, 27 Apr 2015 11:14:22 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Greg Kurz <gkurz@...ux.vnet.ibm.com>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Thomas Huth <thuth@...hat.com>, kvm@...r.kernel.org,
	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH v6 6/8] virtio: add explicit big-endian support to
 memory accessors

On Fri, 24 Apr 2015 14:26:24 +0200
Greg Kurz <gkurz@...ux.vnet.ibm.com> wrote:

> The current memory accessors logic is:
> - little endian if little_endian
> - native endian (i.e. no byteswap) if !little_endian
> 
> If we want to fully support cross-endian vhost, we also need to be
> able to convert to big endian.
> 
> Instead of changing the little_endian argument to some 3-value enum, this
> patch changes the logic to:
> - little endian if little_endian
> - big endian if !little_endian
> 
> The native endian case is handled by all users with a trivial helper. This
> patch doesn't change any functionality, nor it does add overhead.
> 
> Signed-off-by: Greg Kurz <gkurz@...ux.vnet.ibm.com>
> ---
> 
> Changes since v5:
> - changed endian checking helpers as suggested by Thomas (use || and line
>   breaker)
> 
>  drivers/net/macvtap.c            |    3 ++-
>  drivers/net/tun.c                |    3 ++-
>  drivers/vhost/vhost.h            |    3 ++-
>  include/linux/virtio_byteorder.h |   24 ++++++++++++++----------
>  include/linux/virtio_config.h    |    3 ++-
>  include/linux/vringh.h           |    3 ++-
>  6 files changed, 24 insertions(+), 15 deletions(-)
> 

Reviewed-by: Cornelia Huck <cornelia.huck@...ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/